[FileBasedConfiguration] Resources #4462
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
> Co-authored-by: Yevhenii Solomchenko <[email protected]>
Kielek
force-pushed
the
filebasedconfig-resources
branch
from
33e7e00 to
77bc6b7
Compare
it is correctly handled by OTel SDK
Kielek
force-pushed
the
filebasedconfig-resources
branch
from
de21a27 to
91d64bb
Compare
detection of these attributes was moved to resourceconfigurator
RassK
reviewed
Sep 16, 2025
src/OpenTelemetry.AutoInstrumentation/Configurations/ResourceSettings.cs
Outdated
Show resolved
Hide resolved
|
Will you address the TODOs here or later? |
RassK
reviewed
Sep 16, 2025
src/OpenTelemetry.AutoInstrumentation/Configurations/FileBasedConfiguration/Parser/Parser.cs
Show resolved
Hide resolved
RassK
reviewed
Sep 16, 2025
src/OpenTelemetry.AutoInstrumentation/Configurations/ResourceSettings.cs
Outdated
Show resolved
Hide resolved
Follow up PRs. I would like to avoid making this PR bigger. |
RassK
reviewed
Sep 16, 2025
src/OpenTelemetry.AutoInstrumentation/Configurations/ResourceSettings.cs
Outdated
Show resolved
Hide resolved
RassK
reviewed
Sep 16, 2025
src/OpenTelemetry.AutoInstrumentation/Configurations/ResourceSettings.cs
Outdated
Show resolved
Hide resolved
RassK
reviewed
Sep 16, 2025
...Telemetry.AutoInstrumentation/Configurations/FileBasedConfiguration/ResourceConfiguration.cs
Show resolved
Hide resolved
RassK
approved these changes
Sep 17, 2025
...Telemetry.AutoInstrumentation/Configurations/FileBasedConfiguration/ResourceConfiguration.cs
Outdated
Show resolved
Hide resolved
| /// <summary> | ||
| /// Gets or sets the list of enabled resources. | ||
| /// </summary> | ||
| public IReadOnlyList<KeyValuePair<string, object>> Resources { get; set; } = []; |
There was a problem hiding this comment.
for the future, may want to use union ref struct not to cause object boxing for simple types.
src/OpenTelemetry.AutoInstrumentation/Configurations/ConfigurationKeys.cs
Show resolved
Hide resolved
Comment on lines
+57
to
+59
| protected virtual void OnLoadFile(YamlConfiguration configuration) | ||
| { | ||
| } |
There was a problem hiding this comment.
I think this method should also be abstract in the future. It’s worth adding a TODO: that once the implementation is done in all settings, it should be changed to abstract.
Co-authored-by: Yevhenii Solomchenko <[email protected]>
|
@rajkumar-rangaraj, @nrcventura, @zacharycmontoya. I am going to merge to unblock further work on this tasks and NoCode feature. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Towards #4394
Extracted and refactored from #4270
What
File based configuration for resources.
Note
File based configuration should block any direct reads from environmental variables. In this case, it means that Environmental Variable resource detector is not used.
Intentionally keeping documentation and changelog outside scope of this PR. I think that for documentation we need at least one more PR (resource detectors).
Changelog should be mentioned only when we decide ask the end-users to test it.
Tests
CI + added tests
Checklist
[ ]CHANGELOG.mdis updated.[ ] Documentation is updated.